Fix PreallocatedCircuitBreakerService leak #72846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
May 7, 2021
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
May 10, 2021
when overflowing the preallocated buffer, adjust the underlaying breaker before allocating the preallocated bytes
iverase
added a commit
that referenced
this pull request
May 10, 2021
iverase
added a commit
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #66895 we added a circuit breaker that allows pre-allocation of bytes in order to remove hotspots when there are many small allocations happening very fast. Unfortunately it introduced a bug when we overflow the preallocated buffer. In this case we first set the number of bytes and then adjust the breaker. If the breaker trigger at that point, then the preallocated circuit breaker is out of sync and leaks.
This PR changes the order of events, so we first adjust the breaker and then adjust the number of preallocated bytes used.
I have fixed a typo as well: PreallocedCircuitBreaker -> PreallocatedCircuitBreaker
fixes #72760