-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILM: execute cached steps even if policy is updated #75296
Conversation
This makes ILM honour the cached phase even when the underlying policy is updated to not contain the cached actions.
Pinging @elastic/es-core-features (Team:Core/Features) |
* Returns null if there's a parsing error. | ||
*/ | ||
@Nullable | ||
public Set<Step.StepKey> parseStepKeysFromPhase(String phaseDef, String currentPhase) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposed this here for convenience and to reduce the number of dependencies IndexLifecycleTransition
would need if it was to use the PhaseCacheManagement
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this Andrei
This makes ILM honour the cached phase even when the underlying policy is updated to not contain the cached actions.
This makes ILM honour the cached phase even when the underlying policy is updated to not contain the cached actions.
This makes ILM honour the cached phase even when the underlying policy is updated to not contain the cached actions.
This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.
Fixes #66838