Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM: execute cached steps even if policy is updated #75296

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

andreidan
Copy link
Contributor

This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.

Fixes #66838

This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.
@andreidan andreidan requested a review from dakrone July 13, 2021 13:00
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jul 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

* Returns null if there's a parsing error.
*/
@Nullable
public Set<Step.StepKey> parseStepKeysFromPhase(String phaseDef, String currentPhase) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposed this here for convenience and to reduce the number of dependencies IndexLifecycleTransition would need if it was to use the PhaseCacheManagement directly.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this Andrei

@andreidan andreidan added the auto-backport Automatically create backport pull requests when merged label Jul 19, 2021
@andreidan andreidan merged commit e978b72 into elastic:master Jul 19, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 19, 2021
This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 19, 2021
This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.14
7.x

andreidan added a commit that referenced this pull request Jul 19, 2021
This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.

Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
andreidan added a commit that referenced this pull request Jul 19, 2021
This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.

Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
This makes ILM honour the cached phase even when the underlying policy
is updated to not contain the cached actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team v7.14.0 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILM can get stuck in the hot phase during attempt-rollover step if rollover is removed from the policy
6 participants