Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsigned longs should be compatible with index sorting #75599

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Jul 21, 2021

This change allows the type unsigned_long to be used in the index sort specification.
The internal representation uses plain longs so we can rely on the existing support for that type.

This change allows the type `unsigned_long` to be used in the index
sort specification. The internal representation uses plain longs so
we can rely on the existing support for that type.
@jimczi jimczi added >feature :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.15.0 labels Jul 21, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dnhatn
Copy link
Member

dnhatn commented Jul 22, 2021

Relates #72741

@jimczi jimczi merged commit 3b62de9 into elastic:master Jul 26, 2021
@jimczi jimczi deleted the unsigned_long_index_sort branch July 26, 2021 14:45
jimczi added a commit to jimczi/elasticsearch that referenced this pull request Jul 26, 2021
This change allows the type `unsigned_long` to be used in the index
sort specification. The internal representation uses plain longs so
we can rely on the existing support for that type.
jimczi added a commit that referenced this pull request Jul 26, 2021
This change allows the type `unsigned_long` to be used in the index
sort specification. The internal representation uses plain longs so
we can rely on the existing support for that type.
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
This change allows the type `unsigned_long` to be used in the index
sort specification. The internal representation uses plain longs so
we can rely on the existing support for that type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants