Propagate original indices in NodeTermsEnumRequest #77776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix ensures that we provide the original list of indices as part of the node-level terms enum request. Closes elastic#77508
jimczi
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
markharwood
reviewed
Sep 22, 2021
There was a problem hiding this comment.
LGTM - the only question I have is whether the rest tests cover the expected behaviour for the various combinations of security on aliases and underlying indices. E.g.
- Security granted to alias with no conditions on underlying indices
- Security granted to alias with mixed conditions also defined on underlying indices
I think we agreed it was OK for terms_enum to ignore any filters associated with aliases.
This was referenced Oct 6, 2021
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Oct 6, 2021
This fix ensures that we provide the original list of indices as part of the node-level terms enum request. Closes elastic#77508
jimczi
added a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures that we provide the original list of indices
as part of the node-level terms enum request.
Closes #77508