Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] fix version check for beta transforms #78364

Merged

Conversation

hendrikmuhs
Copy link
Contributor

fix the version check for deprecated beta transforms, this was introduced in #77565, but
contained a typo (7.15 instead of 7.5)

Note: For 8.x/master we don't need this check, however we will likely deprecate 7.x transforms,
therefore this check will be re-used. Keeping this in both master and 7.x makes merging easier.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Sep 28, 2021
@hendrikmuhs hendrikmuhs merged commit dfd65be into elastic:master Sep 28, 2021
@hendrikmuhs hendrikmuhs deleted the transform-deprecate-beta-configs branch September 28, 2021 11:15
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this pull request Sep 28, 2021
fix the version check for deprecated beta transforms, this was introduced in elastic#77565, but
contained a typo (7.15 instead of 7.5)
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

elasticsearchmachine pushed a commit that referenced this pull request Sep 28, 2021
)

* [Transform] fix version check for beta transforms (#78364)

fix the version check for deprecated beta transforms, this was introduced in #77565, but
contained a typo (7.15 instead of 7.5)

* Update TransformConfigTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :ml/Transform Transform >non-issue Team:ML Meta label for the ML team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants