SQL: swap JDBC page.timeout and query.timeout properties in query requests #79491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luegg
force-pushed
the
fix/jdbcTimeouts
branch
from
e402ce8
to
69fdb4b
Compare
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
bpintea
reviewed
Oct 26, 2021
| @@ -23,8 +23,8 @@ RequestMeta queryTimeout(long timeout) { | |||
| return this; | |||
| } | |||
|
|
|||
| RequestMeta timeout(long timeout) { | |||
| this.timeoutInMs = timeout; | |||
| RequestMeta pageTimeout(long timeout) { | |||
There was a problem hiding this comment.
Is this method used anywhere?
There was a problem hiding this comment.
it's not, I thought I could keep it for consistency though.
Luegg
added
the
auto-backport-and-merge
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Oct 27, 2021
…uests (elastic#79491) * SQL: swap JDBC page.timeout and query.timeout properties in query requests resolves elastic#79430 * rm reference to elastic#79480 from spec
💔 Backport failed
You can use sqren/backport to manually backport by running |
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Dec 17, 2021
…uests (elastic#79491) * SQL: swap JDBC page.timeout and query.timeout properties in query requests resolves elastic#79430 * rm reference to elastic#79480 from spec # Conflicts: # x-pack/plugin/sql/jdbc/src/main/java/org/elasticsearch/xpack/sql/jdbc/JdbcHttpClient.java # x-pack/plugin/sql/jdbc/src/test/java/org/elasticsearch/xpack/sql/jdbc/JdbcConfigurationDataSourceTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 20, 2021
…ery requests (#79491) (#81878) * SQL: swap JDBC page.timeout and query.timeout properties in query requests (#79491) * SQL: swap JDBC page.timeout and query.timeout properties in query requests resolves #79430 * rm reference to #79480 from spec # Conflicts: # x-pack/plugin/sql/jdbc/src/main/java/org/elasticsearch/xpack/sql/jdbc/JdbcHttpClient.java # x-pack/plugin/sql/jdbc/src/test/java/org/elasticsearch/xpack/sql/jdbc/JdbcConfigurationDataSourceTests.java * fix backport * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #79430
This PR makes sure that the configuration parameters are passed correctly into the query request.