Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Move datafeed stats action off of master node #82271

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

droberts195
Copy link
Contributor

Previously the get datafeed stats action was handled on the
master node. This dated back to the time when datafeed configs
were stored in the cluster state. Now that the action consists
of running a series of searches it can be a handled transport
action.

Previously the get datafeed stats action was handled on the
master node. This dated back to the time when datafeed configs
were stored in the cluster state. Now that the action consists
of running a series of searches it can be a handled transport
action.
@droberts195
Copy link
Contributor Author

Jenkins run elasticsearch-ci/bwc

2 similar comments
@droberts195
Copy link
Contributor Author

Jenkins run elasticsearch-ci/bwc

@droberts195
Copy link
Contributor Author

Jenkins run elasticsearch-ci/bwc

@droberts195 droberts195 marked this pull request as ready for review January 5, 2022 21:02
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jan 5, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a prudent change. The key will be making sure in a mixed cluster environment all is fine.

++ from me

@droberts195 droberts195 added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Jan 6, 2022
@droberts195 droberts195 merged commit 7c35f44 into elastic:master Jan 6, 2022
@droberts195 droberts195 deleted the datafeed_stats_off_master branch January 6, 2022 10:57
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0 Commit could not be cherrypicked due to conflicts
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 82271

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jan 6, 2022
Previously the get datafeed stats action was handled on the
master node. This dated back to the time when datafeed configs
were stored in the cluster state. Now that the action consists
of running a series of searches it can be a handled transport
action.

Backport of elastic#82271
droberts195 added a commit that referenced this pull request Jan 6, 2022
Previously the get datafeed stats action was handled on the
master node. This dated back to the time when datafeed configs
were stored in the cluster state. Now that the action consists
of running a series of searches it can be a handled transport
action.

Backport of #82271
droberts195 added a commit that referenced this pull request Jan 6, 2022
Previously the get datafeed stats action was handled on the
master node. This dated back to the time when datafeed configs
were stored in the cluster state. Now that the action consists
of running a series of searches it can be a handled transport
action.

Backport of #82271
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
Previously the get datafeed stats action was handled on the
master node. This dated back to the time when datafeed configs
were stored in the cluster state. Now that the action consists
of running a series of searches it can be a handled transport
action.
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
Previously the get datafeed stats action was handled on the
master node. This dated back to the time when datafeed configs
were stored in the cluster state. Now that the action consists
of running a series of searches it can be a handled transport
action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >enhancement :ml Machine learning Team:ML Meta label for the ML team v7.17.0 v8.0.0-rc2 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants