Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaled float to the scripting fields API #82275

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Jan 5, 2022

This adds the mapped type scaled float the scripting fields API using double as the base type.

@jdconrad jdconrad added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.1.0 labels Jan 5, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 5, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @jdconrad, I've created a changelog YAML for you.

Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unit tests to FloatDocValuesFieldTests? Looking good otherwise.

@jdconrad
Copy link
Contributor Author

jdconrad commented Jan 5, 2022

@stu-elastic Thanks for the review. I added unit tests as requested. Will commit as soon as CI passes.

@jdconrad jdconrad merged commit e5efade into elastic:master Jan 5, 2022
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
This adds the mapped type scaled float the scripting fields API using double as the base type.
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
This adds the mapped type scaled float the scripting fields API using double as the base type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants