Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. #8232

Merged
merged 1 commit into from Oct 27, 2014
Merged

Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. #8232

merged 1 commit into from Oct 27, 2014

Commits on Oct 27, 2014

  1. Core: Cleanup non nested filter to not flip the bits in the FixedBitS… 

    …et returned by the wrapped filter.

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used.
However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

Closes elastic#8227
Closes elastic#8232
    @martijnvg
    martijnvg committed Oct 27, 2014
    Copy the full SHA
    35ede09 View commit details
    Browse the repository at this point in the history