Fix missing fields in range aggregation response for date fields #82732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a range aggregation on a date field both `fromAsStr` and `toAsStr` need to be parsed to extract the correct range boundaries. Not doing so results in +/- infinite values in `to`, `from`, `originalTo` and `originalFrom` which in turn result in: * incorrect key values (wildcard character used for infinite values); * missing fields in the response (to, from, to_as_string, from_as_string) due to checks for initite values in the serialization logic;
|
This needs to be back-ported to |
salvatore-campagna
added
v7.17.0
v8.0.0
:Analytics/Aggregations
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
salvatore-campagna
added
the
auto-backport
not-napoleon
approved these changes
Jan 18, 2022
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jan 18, 2022
…astic#82732) When running a range aggregation on a date field both `fromAsStr` and `toAsStr` need to be parsed to extract the correct range boundaries. Not doing so results in +/- infinite values in `to`, `from`, `originalTo` and `originalFrom` which in turn result in: * incorrect key values (wildcard character used for infinite values); * missing fields in the response (to, from, to_as_string, from_as_string) due to checks for initite values in the serialization logic;
💔 Backport failed
You can use sqren/backport to manually backport by running |
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jan 18, 2022
…astic#82732) When running a range aggregation on a date field both `fromAsStr` and `toAsStr` need to be parsed to extract the correct range boundaries. Not doing so results in +/- infinite values in `to`, `from`, `originalTo` and `originalFrom` which in turn result in: * incorrect key values (wildcard character used for infinite values); * missing fields in the response (to, from, to_as_string, from_as_string) due to checks for initite values in the serialization logic; (cherry picked from commit 1186e90) # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.aggregation/40_range.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
salvatore-campagna
added a commit
that referenced
this pull request
Jan 18, 2022
…lds (#82732) (#82757) When running a range aggregation on a date field both `fromAsStr` and `toAsStr` need to be parsed to extract the correct range boundaries. Not doing so results in +/- infinite values in `to`, `from`, `originalTo` and `originalFrom` which in turn result in: * incorrect key values (wildcard character used for infinite values); * missing fields in the response (to, from, to_as_string, from_as_string) due to checks for initite values in the serialization logic; (cherry picked from commit 1186e90)
salvatore-campagna
added a commit
that referenced
this pull request
Jan 18, 2022
…ds (#82732) (#82755) When running a range aggregation on a date field both `fromAsStr` and `toAsStr` need to be parsed to extract the correct range boundaries. Not doing so results in +/- infinite values in `to`, `from`, `originalTo` and `originalFrom` which in turn result in: * incorrect key values (wildcard character used for infinite values); * missing fields in the response (to, from, to_as_string, from_as_string) due to checks for initite values in the serialization logic; * Update yaml test skip version after back-port from 8.1.0
albertzaharovits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #82688
When running a range aggregation on a date field both
fromAsStrandtoAsStrneed to be parsed to extract the correct range boundaries.Not doing so results in +/- infinite values in
to,from,originalToand
originalFromwhich in turn result in:due to checks for infinite values in the serialisation logic;
Here we make sure we use the correct from/to values by eventually using
either numeric ranges or parsing string ranges.