Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary DiscoveryService reference from LocalDiscovery #8415

Merged

Conversation

@martijnvg
Copy link
Member

commented Nov 9, 2014

This causes Guice circular dependency issues when local discovery used and plugins are loaded

I noticed this when running plugin tests when plugin.types was set and local discovery was used (which was the default).

Closes #8539

@bleskes

This comment has been minimized.

Copy link
Member

commented Nov 10, 2014

LGTM

Discovery: Removed unnecessary DiscoveryService reference from LocalD…
…iscover, which causes circular Guice dependencies errors.

@martijnvg martijnvg force-pushed the martijnvg:bugs/local-discovery-depedency-issue branch to 0b15859 Nov 12, 2014

@martijnvg martijnvg removed the review label Nov 12, 2014

@martijnvg martijnvg merged commit 0b15859 into elastic:master Nov 12, 2014

@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2014

The problem that this PR fixes only occurs on 1.4.0.Beta1 and 1.4.0

@martijnvg martijnvg deleted the martijnvg:bugs/local-discovery-depedency-issue branch May 18, 2015

@clintongormley clintongormley changed the title Discovery: Removed unnecessary DiscoveryService reference from LocalDiscovery Removed unnecessary DiscoveryService reference from LocalDiscovery Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.