Removed unnecessary DiscoveryService reference from LocalDiscovery #8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
…iscover, which causes circular Guice dependencies errors.
martijnvg
force-pushed
the
bugs/local-discovery-depedency-issue
branch
from
e9d1125
to
0b15859
Compare
|
The problem that this PR fixes only occurs on 1.4.0.Beta1 and 1.4.0 |
clintongormley
added
the
:Distributed/Discovery-Plugins
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes Guice circular dependency issues when local discovery used and plugins are loaded
I noticed this when running plugin tests when
plugin.typeswas set and local discovery was used (which was the default).Closes #8539