-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Enhance multi cluster search test skipping #85566
Conversation
Currently the "skip" section in out rest yaml tests take into account the lowest minor version of nodes in the connected local cluster. For some multi cluster CCS test we will also need the ability to skip certain tests based on the connected remote cluster version, e.g. if in bwc tests some functionality isn't available yet on some bwc versions we test against. This change adds that ability to yaml rest test in the :qa:multi-cluster-search module. Relates to elastic#84481
Pinging @elastic/es-search (Team:Search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, thanks @cbuescher
...ml-rest-runner/src/main/java/org/elasticsearch/test/rest/yaml/ESClientYamlSuiteTestCase.java
Show resolved
Hide resolved
...cluster-search/src/test/java/org/elasticsearch/search/MultiClusterSearchYamlTestSuiteIT.java
Outdated
Show resolved
Hide resolved
...st-runner/src/main/java/org/elasticsearch/test/rest/yaml/ClientYamlTestExecutionContext.java
Outdated
Show resolved
Hide resolved
...cluster-search/src/test/java/org/elasticsearch/search/MultiClusterSearchYamlTestSuiteIT.java
Show resolved
Hide resolved
@javanna I pushed changes that I think simplify this PR quite a bit, I think this is ready for another look |
ab237f2
to
d84d7f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...cluster-search/src/test/java/org/elasticsearch/search/MultiClusterSearchYamlTestSuiteIT.java
Outdated
Show resolved
Hide resolved
Thanks @javanna for the review. |
Currently the "skip" section in out rest yaml tests take into account the lowest minor version of nodes in the connected local cluster. For some multi cluster CCS test we will also need the ability to skip certain tests based on the connected remote cluster version, e.g. if in bwc tests some functionality isn't available yet on some bwc versions we test against. This change adds that ability to yaml rest test in the :qa:multi-cluster-search module. Relates to elastic#84481
Currently the "skip" section in out rest yaml tests take into account the lowest minor version of nodes in the connected local cluster. For some multi cluster CCS test we will also need the ability to skip certain tests based on the connected remote cluster version, e.g. if in bwc tests some functionality isn't available yet on some bwc versions we test against. This change adds that ability to yaml rest test in the :qa:multi-cluster-search module. Relates to #84481
Currently the "skip" section in out rest yaml tests take into account the lowest
minor version of nodes in the connected local cluster. For some multi cluster
CCS test we will also need the ability to skip certain tests based on the
connected remote cluster version, e.g. if in bwc tests some functionality isn't
available yet on some bwc versions we test against. This change adds that
ability to yaml rest test in the :qa:multi-cluster-search module.
Relates to #84481