Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax data path deprecations from critical to warn #85952

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Apr 18, 2022

The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates #85695

The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates elastic#85695
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @rjernst, I've created a changelog YAML for you.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rjernst rjernst added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Apr 18, 2022
@rjernst rjernst merged commit c52ff05 into elastic:master Apr 18, 2022
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Apr 18, 2022
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates elastic#85695
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.2
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 85952

elasticsearchmachine pushed a commit that referenced this pull request Apr 18, 2022
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates #85695
@rjernst rjernst deleted the mdp/deprecation2 branch April 19, 2022 00:02
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Apr 19, 2022
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates elastic#85695
elasticsearchmachine pushed a commit that referenced this pull request Apr 20, 2022
* Relax data path deprecations from critical to warn (#85952)

The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates #85695

* tweak test

* casing...
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Apr 21, 2022
* master: (104 commits)
  fix: ordering terms aggregation on top metrics null values (elastic#85774)
  Fix up whitespace error introduced in elastic#85948
  More docs re. removing cluster.initial_master_nodes (elastic#85948)
  [Test] Remove API key methods from HLRC (elastic#85802)
  Remove references to bootstrap.system_call_filter (elastic#85964)
  Move docker cgroup override to SystemJvmOptions (elastic#85960)
  Add connection accounting tests (elastic#85966)
  Remove MacOS from platform support testing matrix
  Remove custom KnnVectorFieldExistsQuery (elastic#85945)
  Relax data path deprecations from critical to warn (elastic#85952)
  Remove hppc from some "common" classes (elastic#85957)
  Move docker env var settings handling out of bash (elastic#85913)
  Remove hppc from task manager (elastic#85889)
  [ML] rename trained model allocations to assignments (elastic#85503)
  Remove hppc from multi*shard request and responses (elastic#85888)
  Consolidating logging initialization in cli launcher (elastic#85920)
  Convert license tools to use unified cli entrypoint (elastic#85919)
  Add noop detection to node shutdown actions (elastic#85914)
  Adjust SQL expended test output
  TSDB: Add timestamp provider to AggregationExecutionContext (elastic#85850)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/search/aggregations/AggregationExecutionContext.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v7.17.4 v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants