-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VERSION field type in SQL and EQL #87590
Add support for VERSION field type in SQL and EQL #87590
Conversation
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
and add new test cases
- better type checks (avoid unpredictable automatic casts) - support multiple casts - add further test cases
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
…sion_data_type_in_ql' into enhancement/support_version_data_type_in_ql
Pinging @elastic/es-ql (Team:QL) |
Hi @luigidellaquila, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me. But can you give an example of the tests that failed?
docs/changelog/85502.yaml
Outdated
@@ -0,0 +1,6 @@ | |||
pr: 85502 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is no longer needed
@Luegg the failing stack trace was the following:
It reproduced deterministically with a specific seed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
@elasticmachine update branch |
Re-submitting #85502, reverted after a CI failure (error on serialization of ConstantProcessor containing a Version object).
The problem was reported by a randomized test, probably it was not identified during the review phase because it's unlikely to happen on CSV spec test suite, due to relatively small result sets.
The applied fix consists in letting ConstantProcessor manage Version objects as a special case and serialize them directly, without relying on StreamInput/Output generic value serialization.
A more natural solution would have been to let StreamInput/Output manage Version objects natively, but it was discarded because Version is in x-pack and cannot be directly referenced/instantiated in Server module (unless we move it and change its license).
Fixes #83375