New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up disk-threshold decider #8803

Merged
merged 1 commit into from Dec 6, 2014

Conversation

Projects
None yet
5 participants
@s1monw
Contributor

s1monw commented Dec 6, 2014

Instead of iterating all shards of all indices to get all relocating
shards for a given node we can just use the RoutingNode#shardsWithState
method and fetch all INITIALIZING / RELOCATING shards and check if they
are relocating. This operation is much faster and uses pre-build
data-structures.

Relates to #6372

[ALLOCATION] Speed-up disk-threshold decider
Instead of iterating all shards of all indices to get all relocating
shards for a given node we can just use the RoutingNode#shardsWithState
method and fetch all INITIALIZING / RELOCATING shards and check if they
are relocating. This operation is much faster and uses pre-build
data-structures.

Relates to #6372
@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Dec 6, 2014

Contributor

I marked this 1.4.2 since it seems to slow down allocation reasonably see #6372

Contributor

s1monw commented Dec 6, 2014

I marked this 1.4.2 since it seems to slow down allocation reasonably see #6372

@s1monw s1monw assigned s1monw and dakrone and unassigned s1monw Dec 6, 2014

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Dec 6, 2014

Contributor

@bleskes @dakrone a review is needed here please ....

Contributor

s1monw commented Dec 6, 2014

@bleskes @dakrone a review is needed here please ....

@bleskes

This comment has been minimized.

Show comment
Hide comment
@bleskes

bleskes Dec 6, 2014

Member

LGTM. +1 on 1.4.2

Member

bleskes commented Dec 6, 2014

LGTM. +1 on 1.4.2

@dakrone

This comment has been minimized.

Show comment
Hide comment
@dakrone

dakrone Dec 6, 2014

Member

LGTM

Member

dakrone commented Dec 6, 2014

LGTM

@s1monw s1monw merged commit 3cdf266 into elastic:master Dec 6, 2014

@s1monw s1monw deleted the s1monw:speedup_disk_threshold_decider branch Dec 6, 2014

@clintongormley clintongormley changed the title from [ALLOCATION] Speed-up disk-threshold decider to Allocation: Speed-up disk-threshold decider Dec 16, 2014

@clintongormley clintongormley added :Allocation and removed review labels Mar 19, 2015

@clintongormley clintongormley changed the title from Allocation: Speed-up disk-threshold decider to Speed-up disk-threshold decider Jun 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment