Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed-up disk-threshold decider #8803

Merged
merged 1 commit into from
Dec 6, 2014
Merged

Speed-up disk-threshold decider #8803

merged 1 commit into from
Dec 6, 2014

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Dec 6, 2014

Instead of iterating all shards of all indices to get all relocating
shards for a given node we can just use the RoutingNode#shardsWithState
method and fetch all INITIALIZING / RELOCATING shards and check if they
are relocating. This operation is much faster and uses pre-build
data-structures.

Relates to #6372

@s1monw
[ALLOCATION] Speed-up disk-threshold decider
3cdf266 
Instead of iterating all shards of all indices to get all relocating
shards for a given node we can just use the RoutingNode#shardsWithState
method and fetch all INITIALIZING / RELOCATING shards and check if they
are relocating. This operation is much faster and uses pre-build
data-structures.

Relates to elastic#6372
@s1monw
Copy link
Contributor Author

s1monw commented Dec 6, 2014

I marked this 1.4.2 since it seems to slow down allocation reasonably see #6372

@s1monw s1monw assigned s1monw and dakrone and unassigned s1monw Dec 6, 2014
@s1monw
Copy link
Contributor Author

s1monw commented Dec 6, 2014

@bleskes @dakrone a review is needed here please ....

@bleskes
Copy link
Contributor

bleskes commented Dec 6, 2014

LGTM. +1 on 1.4.2

@dakrone
Copy link
Member

dakrone commented Dec 6, 2014

LGTM

@s1monw s1monw merged commit 3cdf266 into elastic:master Dec 6, 2014
@s1monw s1monw deleted the speedup_disk_threshold_decider branch December 6, 2014 22:29
This was referenced Dec 7, 2014
Closed
Closed
@clintongormley clintongormley changed the title [ALLOCATION] Speed-up disk-threshold decider Allocation: Speed-up disk-threshold decider Dec 16, 2014
@clintongormley clintongormley mentioned this pull request Dec 24, 2014
Closed
@clintongormley clintongormley changed the title Allocation: Speed-up disk-threshold decider Speed-up disk-threshold decider Jun 6, 2015
@lcawl lcawl added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. and removed :Allocation labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dakrone dakrone

Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >enhancement v1.4.2 v1.5.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s1monw @bleskes @dakrone @clintongormley @lcawl