-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the _knn_search endpoint #88828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change deprecates the kNN search API in favor of the new 'knn' option inside the search API. The 'knn' option is now the preferred way of performing kNN search.
Pinging @elastic/es-search (Team:Search) |
Hi @jtibshirani, I've created a changelog YAML for you. Note that since this PR is labelled |
8 tasks
This test just failed the PR build.
mayya-sharipova
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Julie, LGTM!
jtibshirani
added a commit
that referenced
this pull request
Aug 3, 2022
This change deprecates the kNN search API in favor of the new 'knn' option inside the search API. The 'knn' option is now the preferred way of performing kNN search. Relates to #87625
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Feb 24, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.
javanna
added a commit
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna
added a commit
that referenced
this pull request
Mar 2, 2023
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
ChrisHegarty
pushed a commit
that referenced
this pull request
Aug 9, 2023
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec. Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>deprecation
:Search Relevance/Vectors
Vector search
Team:Search
Meta label for search team
v8.4.0
v8.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates the kNN search API in favor of the new 'knn' option
inside the search API. The 'knn' option is now the recommended way of running
ANN search.
Relates to #87625