Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the _knn_search endpoint #88828

Merged
merged 6 commits into from Aug 3, 2022
Merged

Deprecate the _knn_search endpoint #88828

merged 6 commits into from Aug 3, 2022

Conversation

jtibshirani
Copy link
Contributor

This change deprecates the kNN search API in favor of the new 'knn' option
inside the search API. The 'knn' option is now the recommended way of running
ANN search.

Relates to #87625

@jtibshirani
Deprecate the _knn_search endpoint
9598750 
This change deprecates the kNN search API in favor of the new 'knn' option
inside the search API. The 'knn' option is now the preferred way of performing
kNN search.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jul 26, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @jtibshirani, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@jtibshirani jtibshirani mentioned this pull request Jul 26, 2022
Closed
8 tasks
@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@jtibshirani jtibshirani added the Team:Clients Meta label for clients team label Jul 28, 2022
@elasticsearchmachine elasticsearchmachine removed the Team:Clients Meta label for clients team label Jul 28, 2022
mayya-sharipova
mayya-sharipova approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Julie, LGTM!

@jtibshirani jtibshirani merged commit 21eb984 into elastic:main Aug 3, 2022
@jtibshirani jtibshirani deleted the knn-endpoint branch August 3, 2022 19:19
jtibshirani added a commit that referenced this pull request Aug 3, 2022
@jtibshirani
Deprecate the _knn_search endpoint (#88828)
8eb65c6 
This change deprecates the kNN search API in favor of the new 'knn' option
inside the search API. The 'knn' option is now the preferred way of performing
kNN search.

Relates to #87625
javanna added a commit to javanna/elasticsearch that referenced this pull request Feb 24, 2023
@javanna
Deprecate _knn_search in the REST spec
2d6e3a7 
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.
@javanna javanna mentioned this pull request Feb 24, 2023
Merged
javanna added a commit that referenced this pull request Mar 2, 2023
@javanna
Deprecate _knn_search in the REST spec (#94103)
767b410 
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna added a commit to javanna/elasticsearch that referenced this pull request Mar 2, 2023
@javanna
Deprecate _knn_search in the REST spec (elastic#94103)
7e7b773 
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna added a commit to javanna/elasticsearch that referenced this pull request Mar 2, 2023
@javanna
Deprecate _knn_search in the REST spec (elastic#94103)
ec43502 
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna added a commit to javanna/elasticsearch that referenced this pull request Mar 2, 2023
@javanna
Deprecate _knn_search in the REST spec (elastic#94103)
d2ec255 
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna added a commit to javanna/elasticsearch that referenced this pull request Mar 2, 2023
@javanna
Deprecate _knn_search in the REST spec (elastic#94103)
31f6b0f 
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna added a commit that referenced this pull request Mar 2, 2023
@javanna
Deprecate _knn_search in the REST spec (#94103) (#94288)
33d8213 
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
javanna added a commit that referenced this pull request Mar 2, 2023
@javanna
Deprecate _knn_search in the REST spec (#94103) (#94290)
4814685 
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
saarikabhasi pushed a commit to saarikabhasi/elasticsearch that referenced this pull request Apr 10, 2023
@javanna @saarikabhasi
Deprecate _knn_search in the REST spec (elastic#94103)
f330c54 
We deprecated the _knn_search endpoint with elastic#88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
ChrisHegarty pushed a commit that referenced this pull request Aug 9, 2023
@javanna @costin
Deprecate _knn_search in the REST spec (#94103)
4712a78 
We deprecated the _knn_search endpoint with #88828 but we missed deprecating it in the REST spec.

Note that the REST spec parser was not aligned with its json schema in that the deprecated section caused an exception to be thrown. The parser is now updated to accept the deprecated section at the endpoint level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayya-sharipova mayya-sharipova mayya-sharipova approved these changes

Assignees
No one assigned
Labels
>deprecation :Search/Vectors Vector search Team:Search Meta label for search team v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtibshirani @elasticsearchmachine @mayya-sharipova @mark-vieira