-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inactive shard flush should wait for ongoing one #89430
Merged
kingherc
merged 8 commits into
elastic:main
from
kingherc:test-failure/87888-flush-on-inactive
Aug 22, 2022
Merged
Inactive shard flush should wait for ongoing one #89430
kingherc
merged 8 commits into
elastic:main
from
kingherc:test-failure/87888-flush-on-inactive
Aug 22, 2022
Commits on Aug 18, 2022
-
Inactive shard flush should wait for ongoing one
org.elasticsearch.indices.flush.FlushIT#testFlushOnInactive would sometimes fail in the following case: * SHARD_MEMORY_INTERVAL_TIME_SETTING is set very low, e.g., 10ms * The regularly scheduled multiple flushes proceed to org.elasticsearch.index.shard.IndexShard#flushOnIdle * There, the first flush will handle e.g., the first document that was indexed. The second flush will arrive shortly after, before the first flush finishes. * The second flush will find that wasActive = true (due to the indexing of the remaining documents), and will set it to false. * However, the second flush will not be executed because waitIfOngoing = false, and there is the ongoing first flush. * No other flush is scheduled (since any next regularly scheduled flush will find wasActive = false), which creates the problem. Solution: if a flush request does not happen, revert active flag, so that a next flush request can happen. Fixes elastic#87888
Configuration menu - View commit details
-
Copy full SHA for c5509c4 - Browse repository at this point
Copy the full SHA c5509c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1285b3 - Browse repository at this point
Copy the full SHA a1285b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdb7a4b - Browse repository at this point
Copy the full SHA bdb7a4bView commit details
Commits on Aug 22, 2022
-
Apply suggestions from code review
Co-authored-by: Henning Andersen <33268011+henningandersen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d1cae13 - Browse repository at this point
Copy the full SHA d1cae13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92e9b3f - Browse repository at this point
Copy the full SHA 92e9b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee32e8 - Browse repository at this point
Copy the full SHA 3ee32e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d23a145 - Browse repository at this point
Copy the full SHA d23a145View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7531b4f - Browse repository at this point
Copy the full SHA 7531b4fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.