Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Terms filter lookup caching should cache values, not filters. #9027
The terms filter lookup mechanism today caches filters. Because of this, the
For instance the issue I was seeing was due to the following scenario:
@jpountz Probably too late to this conversation... but wouldn't it be possible to make this more flexible, choosing what to cache?
My particular use case is that I use lookup quite heavily, and the lists of terms are be quite big. Even though this is slow, it's only slow once...
This change will both increase memory usage on my side(keeping the list of terms) and also slow down things in general. I use a _cache_key which is hour based... So I only pay the full price of lookups once every hour, which is quite ok.
but I still wonder, if it is possible to maintain the option of caching the result filter of a terms lookup filter.