-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snapshot threadpool size doc #93655
Merged
pxsalehi
merged 2 commits into
elastic:main
from
pxsalehi:ps230209-updateThreadpoolSizeDocs
Feb 9, 2023
Merged
Update snapshot threadpool size doc #93655
pxsalehi
merged 2 commits into
elastic:main
from
pxsalehi:ps230209-updateThreadpoolSizeDocs
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a suggested rewording:
- no need to format the heap size as
750 MB
, - we're only talking about the default maximum sizes, the user can change these
- the "if ... otherwise ..." may be a little hard to parse
All nits ofc 😁
Co-authored-by: David Turner <david.turner@elastic.co>
This was referenced Feb 9, 2023
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Feb 9, 2023
Co-authored-by: David Turner <david.turner@elastic.co>
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Feb 9, 2023
Co-authored-by: David Turner <david.turner@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 9, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>docs
General docs changes
Team:Distributed
Meta label for distributed team
Team:Docs
Meta label for docs team
v8.6.2
v8.7.1
v8.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has not been updated when we merged #90282 and #92392.