Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshot threadpool size doc #93655

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Update snapshot threadpool size doc #93655

merged 2 commits into from
Feb 9, 2023

Conversation

pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Feb 9, 2023

This has not been updated when we merged #90282 and #92392.

@pxsalehi pxsalehi added >docs General docs changes :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.6.2 v8.7.1 labels Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Documentation preview:

@pxsalehi pxsalehi added the v8.8.0 label Feb 9, 2023
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team labels Feb 9, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@pxsalehi pxsalehi self-assigned this Feb 9, 2023
DaveCTurner
DaveCTurner approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggested rewording:

  • no need to format the heap size as 750 MB,
  • we're only talking about the default maximum sizes, the user can change these
  • the "if ... otherwise ..." may be a little hard to parse

All nits ofc 😁

docs/reference/modules/threadpool.asciidoc Outdated Show resolved Hide resolved
@pxsalehi @DaveCTurner
Update docs/reference/modules/threadpool.asciidoc
b374d17 
Co-authored-by: David Turner <david.turner@elastic.co>
@pxsalehi pxsalehi merged commit 93a897c into elastic:main Feb 9, 2023
@pxsalehi pxsalehi added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Feb 9, 2023
This was referenced Feb 9, 2023
Merged
Merged
pxsalehi added a commit to pxsalehi/elasticsearch that referenced this pull request Feb 9, 2023
@pxsalehi @DaveCTurner
Update snapshot threadpool size doc (elastic#93655)
9c869e9 
Co-authored-by: David Turner <david.turner@elastic.co>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.6
✅ 8.7

pxsalehi added a commit to pxsalehi/elasticsearch that referenced this pull request Feb 9, 2023
@pxsalehi @DaveCTurner
Update snapshot threadpool size doc (elastic#93655)
d2757b4 
Co-authored-by: David Turner <david.turner@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Feb 9, 2023
@pxsalehi @DaveCTurner
Update snapshot threadpool size doc (#93655) (#93664)
969180d 
Co-authored-by: David Turner <david.turner@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Feb 9, 2023
@pxsalehi @DaveCTurner
Update snapshot threadpool size doc (#93655) (#93663)
a8fb9cf 
Co-authored-by: David Turner <david.turner@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@pxsalehi pxsalehi

Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team v8.6.2 v8.7.1 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxsalehi @elasticsearchmachine @DaveCTurner