Refactor _cluster/stats .nodes.fs deduplication #94780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
:Data Management/Stats
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
changed the title
joegallo
changed the title
masseyke
reviewed
Mar 27, 2023
| deduplicator.add(address2, newFsInfo(path2)); | ||
| FsInfo.Path total = deduplicator.getTotal(); | ||
|
|
||
| // wait a second, this is the super-special case -- you can't actually have two nodes doing this unless something |
There was a problem hiding this comment.
What very interesting thing causes this? It seems to me like it would be a bug that we even got here, right?
There was a problem hiding this comment.
Not that I'm arguing that we ought to be asserting the opposite of what you're saing -- I'm just wondering if behavior in this case ought to even be defined.
There was a problem hiding this comment.
It's a pretty common case in practice, even if it's not at all common in theory. I'll catch up with you offline.
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 28, 2023
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 28, 2023
This was referenced Mar 28, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #94744 and to #24472
Refactors the
ClusterStatsNodesfs deduplication logic in order to make it easier to test, then adds four test scenarios (two of which currently pass, the two that fail are bugs that should be fixed -- I'll be fixing them in other PRs).In the response from
GET _cluster/stats, this section:is currently governed by some logic that de-duplicates by ip address, this PR twiddles the code of that logic around a little bit without actually changing the logic.