Do not refresh unpromotables when fast_refresh set #96753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, unpromotables are not relevant when the index is set to fast_refresh. Therefore, we should not wait on their refresh on wait_until.
Tim-Brooks
added
>non-issue
:Distributed/CRUD
|
Pinging @elastic/es-distributed (Team:Distributed) |
…ables_if_not_fast_refresh
kingherc
approved these changes
Jun 12, 2023
…ables_if_not_fast_refresh
kingherc
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Just had an idea about a quick test you could add to this @Tim-Brooks . Would be useful to include in the PR.
server/src/main/java/org/elasticsearch/action/support/replication/PostWriteRefresh.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, unpromotables are not relevant when the index is set to
fast_refresh. Therefore, we should not wait on their refresh on
wait_until and immediate.