Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on troubleshooting laggy cancellations #97485

Conversation

DaveCTurner
Copy link
Contributor

Today we document that tasks may not react to cancellations immediately,
but in practice it's surprising to users and kind of a bug if they run
for too long after being cancelled. This commit adds a little extra
detail about the information to collect to troubleshoot such a
situation.

Today we document that tasks may not react to cancellations immediately,
but in practice it's surprising to users and kind of a bug if they run
for too long after being cancelled. This commit adds a little extra
detail about the information to collect to troubleshoot such a
situation.
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. v8.10.0 v8.9.1 v7.17.12 labels Jul 10, 2023
@github-actions
Copy link

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team labels Jul 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

complete promptly, use the list tasks API with the `?detailed` parameter to
identify the other tasks the system is running and also use the
<<cluster-nodes-hot-threads>> API to obtain detailed information about the work
the system is doing instead of processing the cancellation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of the cancelled task being completed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ good point, see 78f3b1f

@DaveCTurner DaveCTurner added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Jul 10, 2023
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit ac0c316 into elastic:main Jul 10, 2023
@DaveCTurner DaveCTurner deleted the 2023/07/09/troubleshooting-task-cancellation branch July 10, 2023 10:52
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jul 10, 2023
Today we document that tasks may not react to cancellations immediately,
but in practice it's surprising to users and kind of a bug if they run
for too long after being cancelled. This commit adds a little extra
detail about the information to collect to troubleshoot such a
situation.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jul 10, 2023
Today we document that tasks may not react to cancellations immediately,
but in practice it's surprising to users and kind of a bug if they run
for too long after being cancelled. This commit adds a little extra
detail about the information to collect to troubleshoot such a
situation.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.9
7.17

elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2023
Today we document that tasks may not react to cancellations immediately,
but in practice it's surprising to users and kind of a bug if they run
for too long after being cancelled. This commit adds a little extra
detail about the information to collect to troubleshoot such a
situation.
elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2023
Today we document that tasks may not react to cancellations immediately,
but in practice it's surprising to users and kind of a bug if they run
for too long after being cancelled. This commit adds a little extra
detail about the information to collect to troubleshoot such a
situation.
@rjernst rjernst added v8.9.0 and removed v8.9.1 labels Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. >docs General docs changes Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team v7.17.12 v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants