-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Byte and Short as vector tiles value tag #97619
Conversation
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Hi @iverase, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be nice to have an integration test for this too though,
💔 Backport failed
You can use sqren/backport to manually backport by running |
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored.
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored. # Conflicts: # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/vector-tile/10_basic.yml
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored.
…97673) * Port lucene fix github-12352 to Elasticsearch 7.17 * Update docs/changelog/96721.yaml * Support for Byte and Short as vector tiles value tag (#97619) Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored. # Conflicts: # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/vector-tile/10_basic.yml
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored.
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This PR proposes to add those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored.
fixes #97612