Fix mvt error when returning partial results #98765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
craigtaverner
approved these changes
Aug 23, 2023
| @@ -64,6 +64,10 @@ public static void addPropertyToFeature(VectorTile.Tile.Feature.Builder feature, | |||
| // guard for null values | |||
| return; | |||
| } | |||
| if (value instanceof Map<?, ?> map) { | |||
| // maps should have been flattened already in Maps#flatten but still contains the original maps | |||
There was a problem hiding this comment.
Maps.flatten does include recursive code for this, so it is surprising it does not happen. Perhaps there is a bug in Maps.flatten.
There was a problem hiding this comment.
Maybe but it is used in other places and I thought it was too risky to mess with it. I will check and open an issue if necessary
iverase
added
the
auto-backport-and-merge
This was referenced Aug 23, 2023
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Aug 23, 2023
This PR adds the logic to ignore map objects when adding properties to a tile
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Aug 23, 2023
This PR adds the logic to ignore map objects when adding properties to a tile
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 23, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 23, 2023
dreamquster
pushed a commit
to dreamquster/elasticsearch
that referenced
this pull request
Aug 26, 2023
This PR adds the logic to ignore map objects when adding properties to a tile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #97619, we make stricter the parsing of the query result and we throw an error when we cannot add part of the result to the vector tile. This had an undesirable side effect because the flattened method used to generate tags for the vector tile keeps the original maps.
This PR adds the logic to be able to ignore map objects when adding properties to the tile
fixes #98730