Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform schema v2 #270

Merged
merged 7 commits into from Aug 7, 2023
Merged

Transform schema v2 #270

merged 7 commits into from Aug 7, 2023

Conversation

pzl
Copy link
Member

@pzl pzl commented Jul 13, 2022

Change Summary

Updated the transform definitions to match the new Transform Spec

this involved mostly renaming files and translating from json to yaml

I tested these package changes against this PR: elastic/kibana#140046

You can see that the new transforms are installed below.

image

I added an Endpoint to make sure the data was still making it's way to the Endpoint list.

image

Release Target

next

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If this is a metadata change, I also updated both transform destination schemas to match

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary

Upgrade (from current json-based transform) & downgrade operate successfully

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-03T21:13:20.261+0000

  • Duration: 7 min 26 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@pzl
Copy link
Member Author

pzl commented Jul 18, 2022

It appears that Fleet may not yet support installing packages following the new spec.

Here is the fleet issue tracker for that support: elastic/kibana#134321

@pzl pzl changed the title Transform schema [NOMERGE] Transform schema Jul 19, 2022
@kevinlog kevinlog requested a review from a team as a code owner September 14, 2022 18:20
@kevinlog
Copy link
Contributor

@joeypoon @pzl

I resolved the conflicts in this file by updating go.mod and go.sum in addition to adding the new mappings to the united index.

Let me know if it looks OK to you. I tested installing the package with this change with this PR: elastic/kibana#140046. We can merge if everything goes in on the Fleet side.

@pzl
Copy link
Member Author

pzl commented Sep 14, 2022

@kevinlog looks good, verified the two extra fields (last_checkin_message, components) from Joey's united change are in here. The resulting diff looks correct. I can't self-approve my PR, but all looks good here.

will keep holding until kibana PR gets merged

@kevinlog
Copy link
Contributor

/test

@pzl pzl marked this pull request as ready for review August 3, 2023 21:13
@pzl pzl requested a review from a team as a code owner August 3, 2023 21:13
@pzl pzl changed the title [NOMERGE] Transform schema Transform schema v2 Aug 3, 2023
@pzl pzl requested a review from kevinlog August 3, 2023 21:15
@kevinlog
Copy link
Contributor

kevinlog commented Aug 3, 2023

@pzl

looks good! Can you just confirm that you stood this up and it installed correctly in a locally running stack?

@pzl
Copy link
Member Author

pzl commented Aug 3, 2023

@kevinlog

Yes, This worked correctly in a local stack. Tested three scenarios:

  • fresh install (no bundled endpoint package in kibana, installed this fresh). ✔️
  • upgrade (started with package from main branch, installed, checked that transforms for main (json-style-v1) were running. Then restarted my local EPR to include the new build and kibana upgraded endpoint package (played with manifest version locally to make sure it picked it up) and checked that old transforms were stopped, removed, and the new yml-style-v2 were the ones now running ✔️
  • downgrade put some intentional errors in the package so it downgraded to previous json ones ✔️

Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pzl pzl merged commit f4ade9a into main Aug 7, 2023
5 checks passed
@pzl pzl deleted the transform-schema branch August 7, 2023 12:20
@elasticmachine
Copy link
Contributor

Package endpoint - 8.10.0 containing this change is available at https://epr.elastic.co/search?package=endpoint

pzl added a commit that referenced this pull request Aug 15, 2023
pzl added a commit that referenced this pull request Aug 15, 2023
pzl added a commit that referenced this pull request Aug 15, 2023
pzl added a commit that referenced this pull request Aug 15, 2023
pzl added a commit that referenced this pull request Aug 16, 2023
pzl added a commit that referenced this pull request Dec 12, 2023
Revert "Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)"

This reverts commit 7e59c92
This reverts commit cf54cde
This reverts commit 0d1065c
pzl added a commit that referenced this pull request Dec 12, 2023
…461)

* Revert v3 compliance work

This reverts commit 7e59c92
This reverts commit cf54cde
This reverts commit 0d1065c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants