Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Transform schema v2 (#270)" #411

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Revert "Transform schema v2 (#270)" #411

merged 1 commit into from
Aug 15, 2023

Conversation

pzl
Copy link
Member

@pzl pzl commented Aug 15, 2023 •
edited
Loading

Change Summary

the transform.unattended setting was reverted: #407

which was the driving force for having transform use the v2 schemas. Keeping this at v2 only introduces a transform name change (which would need updating in kibana).

So we will revert the schema change as well, since it has no more benefit

Screenshot of transforms with the old names after package install:

2023-08-15-093504_scrot

Release Target

8.10

@pzl pzl requested a review from a team as a code owner August 15, 2023 12:43
@elasticmachine
Copy link
Contributor

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-15T12:43:37.270+0000

  • Duration: 6 min 34 sec

Steps errors 1

Expand to view the steps failures

Update the Elastic stack
  • Took 0 min 17 sec . View more details here
  • Description: ./scripts/go-tools/bin/elastic-package stack update -v --version 8.11.0

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@pzl pzl merged commit 584f50a into main Aug 15, 2023
3 of 6 checks passed
@pzl pzl deleted the transform-v1 branch August 15, 2023 13:47
pzl added a commit that referenced this pull request Aug 15, 2023
@pzl
Revert "Transform schema v2 (#270)" (#411)
f508ed1 
This reverts commit f4ade9a.
@pzl pzl mentioned this pull request Aug 15, 2023
Merged
pzl added a commit that referenced this pull request Aug 15, 2023
@pzl
Revert "Transform schema v2 (#270)" (#411) (#412)
139c87d
@elasticmachine
Copy link
Contributor

Package endpoint - 8.10.2 containing this change is available at https://epr.elastic.co/search?package=endpoint

pzl added a commit that referenced this pull request Aug 16, 2023
@pzl
Revert "Revert "Transform schema v2 (#270)" (#411)"
b912a33 
This reverts commit 584f50a.
pzl added a commit that referenced this pull request Oct 30, 2023
@pzl
Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)
7e59c92
pzl added a commit that referenced this pull request Dec 12, 2023
@pzl
Revert v3 compliance work
34c30f1 
Revert "Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)"

This reverts commit 7e59c92
This reverts commit cf54cde
This reverts commit 0d1065c
pzl added a commit that referenced this pull request Dec 12, 2023
@pzl
Revert "Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)" (#…
c515860 
…461)

* Revert v3 compliance work

This reverts commit 7e59c92
This reverts commit cf54cde
This reverts commit 0d1065c
pzl added a commit that referenced this pull request Apr 2, 2024
@pzl
Revert "Revert "Transform schema v2 (#270)" (#411)" (#418)
1facf4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl is a code owner automatically assigned from elastic/security-defend-workflows

@paul-tavares paul-tavares Awaiting requested review from paul-tavares paul-tavares is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pzl @elasticmachine @kevinlog