11957 hardware breakpoint set #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsuNa-jp
changed the title
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
AsuNa-jp
changed the title
…tic/endpoint-package into asuka_11957-hardware_breakpoint_set
jdu2600
reviewed
Jan 30, 2023
custom_schemas/custom_process.yml
Outdated
Comment on lines
194
to
197
| description: > | ||
| Check whether a hardware breakpoint is set for the thread. | ||
| Include this field, only if the hardware breakpoint is setted. | ||
| example: "true" |
There was a problem hiding this comment.
This generates a non-fatal warning - "Short descriptions must be single line, and under 120 characters"
You can explicitly set a short description with short:
Suggested change
| description: > | |
| Check whether a hardware breakpoint is set for the thread. | |
| Include this field, only if the hardware breakpoint is setted. | |
| example: "true" | |
| short: Whether a hardware breakpoint was set for the thread. | |
| description: > | |
| Whether a hardware breakpoint was set for the thread. | |
| This field is omitted if false. | |
| example: "true" |
There was a problem hiding this comment.
Thanks! Fixed as suggested!
|
/test |
gabriellandau
force-pushed
the
asuka_11957-hardware_breakpoint_set
branch
from
c2f2616
to
7e136fe
Compare
|
Green build |
Thank you very much of fixing this issue, Gabe! |
AsuNa-jp
changed the title
|
Hi @pzl @gergoabraham ! Could you take a look when you get a chance? |
pzl
approved these changes
Jan 31, 2023
|
@pzl Thanks for reviewing! |
|
Package endpoint - 8.7.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR adds a new field which indicates whether a hardware breakpoint is set for a thread.
Protections team is interested in this information because, for example, hardware breakpoints are used for patch-less hooking to bypass security products/features such as AMSI.
Sample values
see
package/endpoint/data_stream/alerts/sample_event.jsonRelease Target
8.8.0
Q/A
For mapping changes:
makeafter making the schema changes, and committed all changesmetadatachange, I also updated both transform destination schemas to matchFor Transform changes: