Replace more dotted keys #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
joeypoon
approved these changes
Oct 10, 2023
andrewkroh
reviewed
Oct 11, 2023
| @@ -1,2 +1,3 @@ | |||
| dynamic_fields: | |||
| event.ingested: ".*" | |||
There was a problem hiding this comment.
I think dynamic_fields is expecting a flat list of field names. Have you tried quoting the key name like "event.ingested"?
There was a problem hiding this comment.
Yes, I noticed how this was handled in elastic/integrations#8115 uses quotes for this
|
Package endpoint - 8.13.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
replace more instances of yaml dotted-key format to multiline format (for package-spec 3.0)
the semantics of this PR are intended to be identical, only formatting changes