Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace more dotted keys #442

Merged
merged 2 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dynamic_fields is expecting a flat list of field names. Have you tried quoting the key name like "event.ingested"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I noticed how this was handled in elastic/integrations#8115 uses quotes for this

'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
9 changes: 5 additions & 4 deletions package/endpoint/data_stream/heartbeat/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ elasticsearch:
dynamic: false
settings:
index:
sort.field:
- event.ingested
sort.order:
- desc
sort:
field:
- event.ingested
order:
- desc
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dynamic_fields:
event.ingested: ".*"
'event.ingested': ".*"