Skip to content

Commit

Permalink
Upgrade Node to v20.13.1 (#7801)
Browse files Browse the repository at this point in the history
  • Loading branch information
mgadewoll committed May 30, 2024
1 parent 15f3d45 commit a00cffa
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .buildkite/scripts/lifecycle/pre_command.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export GCE_ACCOUNT
GITHUB_TOKEN=$(retry 5 vault read -field=github_token $GITHUB_ACCOUNT)
export GITHUB_TOKEN

DOCKER_BASE_IMAGE=docker.elastic.co/eui/ci:6.4
DOCKER_BASE_IMAGE=docker.elastic.co/eui/ci:6.5
export DOCKER_BASE_IMAGE

GCE_IMAGE=google/cloud-sdk:slim
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.12.1
20.13.1
2 changes: 1 addition & 1 deletion packages/eui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"main": "lib",
"module": "es",
"types": "eui.d.ts",
"docker_image": "20.12.1",
"docker_image": "20.13.1",
"engines": {
"node": "16.x || 18.x || >=20.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/scripts/docker-ci/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# https://github.com/zenato/docker-puppeteer/blob/master/Dockerfile

# >=12.0 required (for cypress). v18 is LTS.
FROM --platform=linux/amd64 node:20.12.1-slim
FROM --platform=linux/amd64 node:20.13.1-slim

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

Expand Down
4 changes: 2 additions & 2 deletions wiki/eui-team-processes/upgrading-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Find and replace all instances of the old Node version in EUI (e.g., `16.18.1`).

### Updating the Docker image version

Once all references to the old Node version have been updated in CI-related files, you'll need to build and publish a new Docker image with the new Node version for CI to use. The steps for this is documented in [`scripts/docker-ci`](https://github.com/elastic/eui/tree/main/scripts/docker-ci#using-with-the-elastic-container-library).
Once all references to the old Node version have been updated in CI-related files, you'll need to build and publish a new Docker image with the new Node version for CI to use. The steps for this is documented in [`scripts/docker-ci`](https://github.com/elastic/eui/tree/main/packages/eui/scripts/docker-ci#using-with-the-elastic-container-library).

#### Updating references to Docker image versions

Expand All @@ -28,7 +28,7 @@ Find all instances of `docker.elastic.co/eui/ci:` in EUI. You will want to chang

#### When upgrading to a minor or patch Node version

For non-major Node upgrades, you will likely only need to follow the [Build a new image](https://github.com/elastic/eui/tree/main/scripts/docker-ci#build-a-new-image) step and [Publish a built image](https://github.com/elastic/eui/tree/main/scripts/docker-ci#publish-a-built-image) step.
For non-major Node upgrades, you will likely only need to follow the [Build a new image](https://github.com/elastic/eui/tree/main/packages/eui/scripts/docker-ci#build-a-new-image) step and [Publish a built image](https://github.com/elastic/eui/tree/main/packages/eui/scripts/docker-ci#publish-a-built-image) step.

#### When upgrading to major Node versions

Expand Down

0 comments on commit a00cffa

Please sign in to comment.