Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BetaBadge] Add alignment prop #6358

Closed
2 tasks
chandlerprall opened this issue Nov 14, 2022 · 2 comments · Fixed by #6361
Closed
2 tasks

[BetaBadge] Add alignment prop #6358

chandlerprall opened this issue Nov 14, 2022 · 2 comments · Fixed by #6361
Assignees

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Nov 14, 2022

See the Beta badge type example,

TODO

  • Add new prop for alternative alignments (e.g. baseline, middle, super)
  • [Proposed] set default to baseline

Screen Shot 2022-11-14 at 11 35 38 AM

Reported by Discover(elastic/kibana#144655) and the synthetics recorder team.

@chandlerprall
Copy link
Contributor Author

Nvm, the super alignment is the intended location; that positioning was shifted to the current location through recent css value tweaks, but it's working as expected.

@ryankeairns ryankeairns changed the title [BetaBadge] badge no longer lines up with its line of text [BetaBadge] Add alignment prop Nov 14, 2022
@ryankeairns
Copy link
Contributor

There are use cases where the super alignment is not always desirable. In a Slack thread, we gained consensus for adding a prop with alternate vertical alignment options (e.g. super, baseline, middle).

@ryankeairns ryankeairns added the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Nov 14, 2022
@ryankeairns ryankeairns reopened this Nov 14, 2022
@miukimiu miukimiu removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Nov 15, 2022
@miukimiu miukimiu self-assigned this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants