Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBetaBadge] Add alignment prop #6361

Merged
merged 6 commits into from
Nov 18, 2022
Merged

[EuiBetaBadge] Add alignment prop #6361

merged 6 commits into from
Nov 18, 2022

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Nov 15, 2022 •
edited

Summary

This PR adds a new alignment prop to EuiBetaBadge and closes #6358.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6361/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6361/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6361/

@miukimiu miukimiu marked this pull request as ready for review November 16, 2022 14:44
cee-chen
cee-chen reviewed Nov 16, 2022
View reviewed changes
src/components/badge/beta_badge/beta_badge.tsx Outdated
Comment on lines 33 to 34
export const ALIGNMENTS = ['baseline', 'middle', 'super'] as const;
export type BetaBadgeAlignment = typeof ALIGNMENTS[number];
Copy link
Member

@cee-chen cee-chen Nov 16, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I like/prefer limiting the options here, but just wanted to throw this out there - do we anticipate wanting to support all values of vertical-align (e.g. sub, top, text-bottom, etc...)?

Just thinking out loud, but if we see that kind of wildcard support being a possible future usecase, what we could also do instead of setting an enum is to make it an inline style instead of an Emotion class 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the users will never change this. I think the main issue here was the super was not looking as before because of that overflow: hidden.

But I see a possibility of some consumers aligning in the middle. But the super option.. Not sure... I'm even thinking if it should be here. It doesn't look good. 😬

@miukimiu
Copy link
Contributor Author

@constancecchen I decided to remove the alignment option super. IMO it doesn't look good so we shouldn't enforce that option.

badge-alignments@2x

I see use cases for baseline (default) and middle. So I think for now we should only have these options.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6361/

@cee-chen
Copy link
Member

I'm good with that! We can always tweak in the future without being a breaking change if someone requests more alignment types later.

@miukimiu miukimiu merged commit 004cc1b into elastic:main Nov 18, 2022
@1Copenut 1Copenut mentioned this pull request Nov 21, 2022
Merged
1Copenut added a commit to elastic/kibana that referenced this pull request Dec 2, 2022
@1Copenut @cee-chen
Bumping EUI to v70.4.0 (#145888)
7376d9c 
`eui@70.2.4` ⏩ `eui@70.4.0`

- "Fixed EuiButtonGroup firing onChange twice" required changing some
tests from `click` to `change`
___

## [`70.4.0`](https://github.com/elastic/eui/tree/v70.4.0)

- Updated `EuiTourStep.footerAction` type to accept `ReactNode[]`
([#6384](elastic/eui#6384))
- Vertically aligned all footer content so that `euiTourStepIndicator`
is always centered ([#6384](elastic/eui#6384))
- Added `filterInCircle` glyph to `EuiIcon`
([#6385](elastic/eui#6385))
- Added `color` prop to `EuiBeacon`
([#6420](elastic/eui#6420))
- Added the `euiMaxBreakpoint` and `euiMinBreakpoint` CSS-in-JS
utilities for creating min/max-width media queries
([#6431](elastic/eui#6431))

**Bug fixes**

- Restores the previous match operator behaviour when the query value is
split into multiple terms after analysis.
([#6409](elastic/eui#6409))
- Fixed missing slide-in animation on `EuiCollapsibleNav`s and left-side
`EuiFlyout`s ([#6422](elastic/eui#6422))
- Fix bug in `EuiCard` where footer were not aligned to the bottom of
the card ([#6424](elastic/eui#6424))
- Fixed multiple component media queries for consumers with custom theme
breakpoints ([#6431](elastic/eui#6431))

## [`70.3.0`](https://github.com/elastic/eui/tree/v70.3.0)

- `EuiSearchBar` now automatically wraps special characters not used by
query syntax in quotes
([#6356](elastic/eui#6356))
- Added `alignment` prop to `EuiBetaBadge`
([#6361](elastic/eui#6361))
- `EuiButton` now accepts `minWidth={false}`
([#6373](elastic/eui#6373))

**Bug fixes**

- Fixed `EuiPageTemplate` not correctly passing the `component` prop to
the inner main content wrapper.
([#6352](elastic/eui#6352))
- `EuiSkipLink` now correctly calls `onClick` even when
`fallbackDestination` is invalid
([#6355](elastic/eui#6355))
- Permanently fixed `EuiModal` to not cause scroll-jumping issues on
modal open ([#6360](elastic/eui#6360))
- Re-fixed `EuiPageSection` not correctly merging `contentProps.css`
([#6365](elastic/eui#6365))
- Fixed `EuiTab` not defaulting to size `m`
([#6366](elastic/eui#6366))
- Fixed the shadow sizes of `.eui-yScrollWithShadows` and
`.eui-xScrollWithShadows`
([#6374](elastic/eui#6374))
- Fixed bug in `EuiCard` where the inner content in vertical cards was
not growing 100% in width
([#6377](elastic/eui#6377))
- Fixed incorrect margins in `EuiSuperDatePicker` caused by `EuiFlex`
CSS gap change ([#6380](elastic/eui#6380))
- Fixed visual bug in nested `EuiFlexGroup`s, where the parent
`EuiFlexGroup` is responsive but a child `EuiFlexGroup` is not
([#6381](elastic/eui#6381))

**CSS-in-JS conversions**

- Converted `EuiModal` to Emotion
([#6321](elastic/eui#6321))

**Fixes**

- `EuiButton` no longer outputs unnecessary inline styles for
`minWidth={0}` or `minWidth={false}`
([#6373](elastic/eui#6373))
- `EuiFacetButton` no longer reports type issues when passing props
accepted by `EuiButton`
([#6373](elastic/eui#6373))

Co-authored-by: Constance Chen <constance.chen@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BetaBadge] Add alignment prop
3 participants
@miukimiu @kibanamachine @cee-chen