Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow devserver to be served from any host #1223

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Sep 28, 2018

Summary

Tells the webpack dev server to accept connections to any host name. This allows remote machines (and VMs) to connect by IP address without ngrok or similar.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added
- [ ] A changelog entry exists and is marked appropriately
- [ ] This was checked for breaking changes and labeled appropriately
- [ ] Jest tests were updated or added to match the most common scenarios
- [ ] This was checked against keyboard-only and screenreader scenarios

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm likely a poor reviewer of this, but I at least read the docs to see how this works. Assume there isn't any silly security bit we should be aware of here, since this is just for local dev?

@chandlerprall
Copy link
Contributor Author

Assume there isn't any silly security bit we should be aware of here, since this is just for local dev?

Correct, because this is for local dev. Technically it is opening up the dev server to a [potential] broader connection, but so many other things are still in play both physically and through obscurity that there isn't a practical implication.

@chandlerprall chandlerprall merged commit 75da302 into elastic:master Sep 28, 2018
@chandlerprall chandlerprall deleted the feature/allow-all-hosts-on-devserver branch September 28, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants