Makes styles in the style guide hot reloadable #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevacqua
reviewed
Oct 24, 2017
| mask: url('../src/components/icon/assets/check.svg') center center no-repeat; | ||
| // This path is relative to ~/docs/postcss.config.js, which uses | ||
| // the postcss-line-svg plugin. | ||
| mask: svg-load('../src/components/icon/assets/check.svg') center center no-repeat; |
There was a problem hiding this comment.
This sounds super hacky to me. My brain immediately goes "why does src need to know about something docs is doing". Should the postcss configuration live in src instead?
bevacqua
approved these changes
Oct 24, 2017
|
Raised #23 to cover moving the config. |
|
Woot! |
This was referenced Oct 24, 2017
cee-chen
pushed a commit
to cee-chen/eui
that referenced
this pull request
Nov 5, 2021
…es-examples Miukimiu writing guidelines examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs site now pulls in the light and dark themes directly, which means they can hot-load changes. To make this work, I had to inline a SVG file in
checkbox.scss, which I've done with a PostCSS plugin. This also has the benefit of fixing an issue with the distributable styles.