width attribute for EuiTable cell components
#2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
changed the title
width attribute for EuiTable cell components
chandlerprall
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After converting the
EuiTablesuite to TypeScript, obsoletetableelement DOM attributes likewidthstopped being accepted (TdHTMLAttributes<HTMLTableCellElement>does not extend obsolete attributes).widthis still a desirable property, and one that EUI explicitly supported in some cases.This explicitly adds
widthto table cell components and uses the recommended CSS transfer to apply the style.Note that other obsolete attributes are no longer supported, but would still be applied via
{...rest}with// @ts-ignore. Closes #2436.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes