Unmount enzyme components after test execution #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
commented
Apr 4, 2020
|
|
||
| test('sets `cloneItems` on proprietary context', () => { | ||
| const handler = jest.fn(); | ||
| const component = mount( |
There was a problem hiding this comment.
Had to move these mounts into the test themselves, otherwise the auto-unmounting was executing before the assertions
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3255/ |
thompsongl
approved these changes
Apr 6, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out enzyme does not attempt to unmount or cleanup components after executing. It makes sense, but is unfortunate. The impact to us has mostly been through the MutationObserver polyfill singleton yelling about too many listeners and possible memory leak. Turns out there was a memory leak.
mountand stores a reference to the returned componentafterEachto unmount any still-mounted componentsbumpedun-bumped?cratered the MutationObserver polyfill's setMaxListeners back to a reasonable numberChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately