A couple fixes for 7.10 #4084
Merged
A couple fixes for 7.10 #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 30, 2020 13:50
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4084/ |
thompsongl
approved these changes
Sep 30, 2020
kshitij86
added a commit
to kshitij86/eui
that referenced
this pull request
Nov 29, 2020
* [EuiButtonEmpty] Adds `both` to `flush` prop * [EuiRange & EuiDualRange] Fix when to display the `.euiRange__horizontalSpacer` * [EuiFieldSearch] Fix padding for different states * [EuiCheckableCard] Better disabled but checked styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly stylistic fixes...
1. [EuiButtonEmpty] Added
bothtoflushpropCloses #4012. Made this a priority to help the Core UI (@MichaelMarcialis).
2. [EuiRange & EuiDualRange] Fix when to display the
.euiRange__horizontalSpacerThis spacer was only supposed to show when the input is being displayed inline. The logic wasn't correct though, which made it always show unless it was the input with dropdown style.
3. [EuiFieldSearch] Fix padding for different states
The current padding affording for the clearable icon wasn't also affording for being mixed with
isLoadingandcompressedstates. This adds more mixin usages for these states.4. [EuiCheckableCard] Better disabled but checked styles
I saw this usage in Kibana where a checked card was also disabled but the blue border was too prominant.
So this PR simply moves the addition of the blue border to only occur if the item is checked but not disabled.
Checklist
[ ] Checked in mobile[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes