[EuiHorizontalStep] Added current status
#4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4911/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4911/ |
|
In talking with @cchaos, we think it makes sense to add |
added 3 commits
July 26, 2021 11:38
# Conflicts: # CHANGELOG.md
*Breaking* Makes EuiHorizontalStep current default to `incomplete`
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4911/ |
cchaos
changed the title
cchaos
changed the title
current status
added 2 commits
July 26, 2021 15:12
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4911/ |
|
Ok, this one is ready for review again 馃槈 . The summary was also updated. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4911/ |
cchaos
pushed a commit
to myasonik/eui
that referenced
this pull request
Jul 27, 2021
Co-authored-by: cchaos <caroline.horn@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
credit @cnasikas for the spot.
Hopefully I still remember how to code 馃槃
@cchaos has taken over 馃槒
Default state of horizontal step should be
incompletenotundefined. This aligns it with the proper usage which differs from our vertical steps since we want to always denote progress. The docs were also fixed from using deprecated props, to the correctstatus.Which also meant adding
currentas a possiblestatusoption.Default theme
Step 3 looks "broken" in this screenshot, but it's technically correct since there should only be one current/selected step, I'm just showing how using either prop still works.
Amsterdam
Checklist
[ ] Checked in mobileChecked in Chrome, Safari, Edge, and FirefoxChecked for accessibility including keyboard-only and screenreader modes