Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v36.1.0 #107231

Merged
merged 7 commits into from Aug 5, 2021
Merged

Upgrade EUI to v36.1.0 #107231

merged 7 commits into from Aug 5, 2021

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jul 29, 2021 •
edited

Summary

eui@36.0.0 ⏩ eui@36.1.0

Most snapshot changes are from elastic/eui#4663 adding a style prop

36.1.0

  • Fixed color of html scrollbar in dark mode (#4969)
  • Updated EuiMarkdownFormat to use EuiHorizontalRule and better render tables, code blocks and blockquotes (#4663)
  • Updated the EuiMarkdownFormat to use EuiText as a wrapper to handle all the CSS styling (#4663)
  • Updated EuiTexts color prop to accept inherit and custom colors. Updated the size prop to accept relative (#4663)
  • Updated EuiTexts blockquote font-size/line-height to match the base font-size/line-height which is the same as paragraphs (#4663)
  • Added markdownFormatProps prop to EuiMarkdownEditor to extend the props passed to the rendered EuiMarkdownFormat (#4663)
  • Added optional virtualized line rendering to EuiCodeBlock (#4952)
  • Added current as a status of EuiHorizontalStep (#4911)
  • Improved accessibility of EuiBreadcrumbs (#4763)
  • Exported onChange type for EuiSearchBar (#4968)
  • Added warnOnce service (#4984)
  • Added a console warning for the deprecation of EuiCodeEditor (#4984)

Bug fixes

  • Fixed filter count of 0 in EuiSearchBar (#4977)
  • Fixed edge case where EuiDataGrid cells could create an infinite loop of focus changes (#4983)

Theme: Amsterdam

  • Updated styles for EuiLink (#4979)

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.15.0 labels Jul 29, 2021
@chandlerprall chandlerprall marked this pull request as ready for review August 3, 2021 18:35
@chandlerprall chandlerprall requested a review from a team August 3, 2021 18:35
@chandlerprall chandlerprall requested review from a team as code owners August 3, 2021 18:35
@chandlerprall chandlerprall requested a review from a team August 3, 2021 18:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

cjcenizal
cjcenizal approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Stack Management snapshots LGTM!

spong
spong approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a test change on the Security Solution side -- LGTM! Thanks @chandlerprall! 🙂

kertal
kertal approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp owner review, just a snap changed

poffdeluxe
poffdeluxe approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation changes LGTM

mattkime
mattkime approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot changes lgtm

@chandlerprall
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner August 5, 2021 16:28
@kibanamachine kibanamachine requested a review from a team August 5, 2021 16:28
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.6MB 1.6MB +1.9KB
discover 509.3KB 509.8KB +568.0B
expressionError 26.6KB 27.1KB +568.0B
inputControlVis 83.0KB 83.3KB +284.0B
lens 1.6MB 1.6MB +3.3KB
maps 3.2MB 3.2MB +852.0B
ml 6.0MB 6.0MB +284.0B
security 774.8KB 775.1KB +284.0B
securitySolution 6.5MB 6.5MB +90.0B
triggersActionsUi 1.6MB 1.6MB +2.8KB
visDefaultEditor 224.6KB 225.1KB +568.0B
visTypeTable 103.4KB 104.0KB +568.0B
visTypeTimeseries 1003.9KB 1004.2KB +284.0B
visTypeVega 2.4MB 2.5MB +1.1KB
visTypeVislib 564.4KB 564.9KB +568.0B
visualizations 101.5KB 101.8KB +284.0B
total +14.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 421.5KB 423.0KB +1.4KB
data 790.3KB 791.1KB +852.0B
kbnUiSharedDeps-css 522.2KB 534.1KB +11.9KB
kbnUiSharedDeps-elastic 2.6MB 2.6MB +6.5KB
kbnUiSharedDeps-js 6.5MB 6.5MB +1.0B
kibanaReact 150.3KB 150.6KB +284.0B
total +21.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chandlerprall chandlerprall merged commit c2e8343 into elastic:master Aug 5, 2021
@chandlerprall chandlerprall deleted the eui/36-1-0 branch August 5, 2021 19:00
@chandlerprall chandlerprall mentioned this pull request Aug 5, 2021
Merged
chandlerprall added a commit that referenced this pull request Aug 5, 2021
@chandlerprall
Upgrade EUI to v36.1.0 (#107231) (#107799)
3f60e39 
* Upgrade eui to v36.1.0

* Jest snapshots

* More jest snapshots; one test assertion update

* Bump core page load limit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@chandlerprall @kibanamachine @vadimkibana
Upgrade EUI to v36.1.0 (elastic#107231)
0326650 
* Upgrade eui to v36.1.0

* Jest snapshots

* More jest snapshots; one test assertion update

* Bump core page load limit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 9, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
699d458 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (392 commits)
  update linting doc (elastic#105748)
  [APM] Various improvements from elastic#104851 (elastic#107726)
  Update dependency @elastic/charts to v33.2.0 (master) (elastic#107842)
  Fix default route link on kibana homepage (elastic#107809)
  [APM] Invalidate trackPageview on route change (elastic#107741)
  Service map backend links (elastic#107317)
  [index patterns] index pattern create modal (elastic#101853)
  [RAC] integrating rbac search strategy with alert table (elastic#107242)
  [Security Solution] Siem signals -> alerts as data field and index aliases (elastic#106049)
  [Metrics UI] Add checkbox to optionally drop partial buckets (elastic#107676)
  [Metrics UI] Fix metric threshold preview regression (elastic#107674)
  Disable Product check in @elastic/elasticsearch-js (elastic#107642)
  [App Search] Migrate Crawler Status Indicator, Crawler Status Banner, and Crawl Request polling (elastic#107603)
  [Security Solution, Lists] Replace legacy imports from 'elasticsearch' package (elastic#107226)
  [maps] asset tracking tutorial (elastic#104552)
  [scripts/build_ts_refs] when using `--clean` initialize caches (elastic#107777)
  Upgrade EUI to v36.1.0 (elastic#107231)
  [RAC] [TGrid] Implements cell actions in the TGrid (elastic#107771)
  Realign cypress/ccs_integration with cypress/integration (elastic#107743)
  Allow optional OSS to X-Pack dependencies (elastic#107432)
  ...

# Conflicts:
#	x-pack/examples/reporting_example/public/application.tsx
#	x-pack/examples/reporting_example/public/components/app.tsx
#	x-pack/plugins/canvas/public/services/legacy/stubs/reporting.ts
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/lib/reporting_api_client/context.tsx
#	x-pack/plugins/reporting/public/management/mount_management_section.tsx
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/plugin.ts
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
#	x-pack/plugins/reporting/server/export_types/printable_pdf/execute_job/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

@kertal kertal kertal approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@neptunian neptunian neptunian approved these changes

@spong spong spong approved these changes

@jbudz jbudz jbudz approved these changes

@jportner jportner jportner approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet