Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS-in-JS] Convert EuiTextDiff #6056

Merged
merged 4 commits into from Jul 20, 2022
Merged

[CSS-in-JS] Convert EuiTextDiff #6056

merged 4 commits into from Jul 20, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jul 18, 2022 •
edited

Summary

Converts EuiTextDiff to @emotion styling

Checklist

  • Checked in both light and dark modes
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl mentioned this pull request Jul 18, 2022
Open
49 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6056/

@thompsongl thompsongl marked this pull request as ready for review July 18, 2022 16:25
miukimiu
miukimiu approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

I looked at the code and tested it in Chrome, Safari, Edge, and Firefox.

@thompsongl thompsongl merged commit 5916088 into elastic:main Jul 20, 2022
@cee-chen cee-chen mentioned this pull request Jul 27, 2022
Closed
@cee-chen cee-chen mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miukimiu miukimiu miukimiu approved these changes

Assignees
No one assigned
Labels
emotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thompsongl @kibanamachine @miukimiu