Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Fix missing cell popover shadows in Safari #6163

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Aug 23, 2022

Summary

closes #6151 - see issue for more discussion/context

Before:

After:

Checklist

  • Checked in Chrome, Safari, Edge, and Firefox
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6163/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested the preview build with chrome/edge/ff/safari (on Mac). Safari looks good again, and I don't see a difference in the others

@cee-chen cee-chen enabled auto-merge (squash) August 23, 2022 22:03
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6163/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Cell expansion missing border in Safari
3 participants