Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Cell expansion missing border in Safari #6151

Closed
kertal opened this issue Aug 22, 2022 · 2 comments · Fixed by #6163
Closed

[DataGrid] Cell expansion missing border in Safari #6151

kertal opened this issue Aug 22, 2022 · 2 comments · Fixed by #6163

Comments

@kertal
Copy link
Member

kertal commented Aug 22, 2022

With some of the latest changes EuiDataGrid's cell expansion is missing a border /shadow when using Safari

Safari 15.5
Bildschirmfoto 2022-08-22 um 15 00 13
*Chrome 104

Bildschirmfoto 2022-08-22 um 15 03 45

Noticed while testing Safari

@chandlerprall
Copy link
Contributor

Confirmed for me in Safari 15.4; looks like the shadow is present in those rounded corners but clipped to the element's bounding box.

@cee-chen
Copy link
Member

cee-chen commented Aug 23, 2022

It's the overflow: auto on .euiDataGridRowCell__popover combined with the new filter: drop-shadow (vs box-shadow) added in #5977:

Unfortunately, we need that overflow: auto for cells with very large content:

Based on the Emotion PR, the switch to filter was added to accommodate the popover arrow which EuiDataGrid simply doesn't need (we hide the arrow). I'm leaning towards removing the filter for EuiDataGrid and re-adding the box-shadow CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants