-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech debt] Create new internal util for rendering semantic <a>
/<button>
elements
#7533
Draft
cee-chen
wants to merge
10
commits into
elastic:main
Choose a base branch
from
cee-chen:link-or-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Feb 16, 2024
-
[organization] Rename
src/services/security
tosrc/services/links
- all logic is related to links, and I'm shortly about to add some DRY logic that is link adjacent but not security adjacent that will use these utils, so it feels like it makes sense to group them all together
Configuration menu - View commit details
-
Copy full SHA for 8f263eb - Browse repository at this point
Copy the full SHA 8f263ebView commit details -
Export
validateHref
as top-level service- and update component imports
Configuration menu - View commit details
-
Copy full SHA for 8db3b92 - Browse repository at this point
Copy the full SHA 8db3b92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 935de0e - Browse repository at this point
Copy the full SHA 935de0eView commit details -
Handle Emotion css output/order
- gets slightly messed by the new component, we need to semi-brute-force it
Configuration menu - View commit details
-
Copy full SHA for 17b6ecd - Browse repository at this point
Copy the full SHA 17b6ecdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35faedb - Browse repository at this point
Copy the full SHA 35faedbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 648e298 - Browse repository at this point
Copy the full SHA 648e298View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3625ab1 - Browse repository at this point
Copy the full SHA 3625ab1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78d91e6 - Browse repository at this point
Copy the full SHA 78d91e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for abac60c - Browse repository at this point
Copy the full SHA abac60cView commit details -
[EuiButton] Remove
element
prop- the component will now automatically detect this
Configuration menu - View commit details
-
Copy full SHA for 3d3453d - Browse repository at this point
Copy the full SHA 3d3453dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.