[EuiComboBox] add support for option tooltips #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
commented
Apr 18, 2024
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Show resolved
Hide resolved
mgadewoll
force-pushed
the
feat/7690-combobox-option-tooltip-support
branch
from
623e956
to
c580005
Compare
12 tasks
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
requested changes
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
|
@mgadewoll Thanks so much with your patience waiting for my review on this, and for your amazing work with granular commits that made it super easy to follow!! My largest comments I'd like to see resolved are:
Everything other comment is just nice to have. I'll skip reviewing the EuiSelectable version of this PR as well (assuming it has similar-ish comments to the above) until this PR is settled and merged in if that's cool! |
cee-chen
force-pushed
the
feat/7690-combobox-option-tooltip-support
branch
2 times, most recently
from
759f203
to
685209d
Compare
|
ℹ️ I added baseline VRT references for |
Yasss that would be amazing! I reiterate that you are the best! |
cee-chen
approved these changes
May 3, 2024
…/hide instead for options - dry out prop types - update tests
+ clean up comments + remove now-unnecessary setTimeout workaround, this one is stronker
-use const as type - revert newline changes
mgadewoll
force-pushed
the
feat/7690-combobox-option-tooltip-support
branch
from
0b7cb47
to
9929c3e
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
jbudz
pushed a commit
to elastic/kibana
that referenced
this pull request
May 10, 2024
`v94.2.1-backport.0` ⏩ `v94.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v94.3.0`](https://github.com/elastic/eui/releases/v94.3.0) - Updated `launch` glyph for `EuiIcon` ([#7670](elastic/eui#7670)) - Updated `EuiComboBox`'s `options` to support including tooltip details for selectable options. Use `toolTipContent` to render tooltip information, and `toolTipProps` to optionally customize the tooltip rendering behavior ([#7700](elastic/eui#7700)) - Updated the following existing glyphs in `EuiIcon`: ([#7727](elastic/eui#7727)) - `error` (now an outlined version instead of filled) - `tokenMetricCounter` - `tokenMetricGauge` - Added the following new glyphs to `EuiIcon`: ([#7727](elastic/eui#7727)) - `tokenDimension` - `clickLeft` - `clickRight` - `clockCounter` - `errorFilled` (the previous `error` glyph design) - `warningFilled` **Bug fixes** - Fixed a visual layout bug for `EuiComboBox` with `isLoading` in mobile views ([#7700](elastic/eui#7700)) - Fixed missing styles on header cells of `EuiDataGrid` that prevented content text alignment styles to apply ([#7720](elastic/eui#7720)) - Fixed `EuiFlexGroup` and `EuiFlexItem` `ref` prop typing to support refs of the same type as the passed `component` type and allow `displayName` to be defined for easy component naming when using component wrappers like `styled()` ([#7724](elastic/eui#7724)) --- Most of the code changes you'll see in this PR are caused by the recent EuiFlex* changes making it generic. This, unfortunately, is something that `styled()` doesn't always like. I replaced the failing usages of `styled(EuiFlexGroup)` and `styled(EuiFlexItem)` to use `component` and other native EuiFlex* props, resulting in the same output but being better typed. We plan to add more props to EuiFlex* components giving developers control over properties like `flex-grow` and `flex-shring`, and reducing the need for writing any custom CSS when using these components. This should reduce the number of `styled()` wrappers needed even further --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first part of updates for #7690
This PR updates
EuiComboBoxto support the two propstoolTipContentandtoolTipPropsto be passed to combobox options to display a tooltip on hover/focus.To ensure the tooltip can be opened on focus, the
EuiToolTipwas updated to a support controlled behavior viaisOpen.QA
EuiComboBoxin storybook and docs and/or checkout this PR locally viagh pr checkout 7700General checklist
@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesIf applicable, added the breaking change issue label (and filled out the breaking change checklist)