Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Revert removed setTimeout on EuiInputPopover scroll listener #7760

Merged

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented May 15, 2024

Summary

closes #7761

This PR reverts earlier changes done in this PR which remove a setTimeout on EuiInputPopover's scroll listener.
This change triggered flaky e2e test behaviors in Kibana (observed from version 94.3.0).

QA

Verifying fix on Kibana

  1. on EUI side
  • checkout this PR: gh pr checkout 7760
  • build the package locally in packages/eui with yarn build-pack
  1. on Kibana side
  • follow the steps listed in this wiki to add the local package to Kibana
  • run Kibana locally (yarn es snapshot, yarn kbn bootstrap --no-validate && yarn start)
  • navigate to the security_solution test directory and run the cypress tests
cd x-pack/test/security_solution_cypress
yarn cypress:open:ess
  • wait until the tests are up and running and choose the test rule_creation/common_flows.cy.ts to run
  • verify the test finishes (on the broken version the test hangs when navigating combo boxes and won't finish)
  • rerun the test a couple times to be sure it's not flaky

Verifying Firefox issue around unexpectedly closing combobox panel on hover is still fixed

🔗 Issue conversation

  • open the tooltips section of the EUI docs for EuiComboBox in Firefox
  • click the input of EuiComboBox for opening the popover panel
  • hover the option items
  • verify the panel stays open

@mgadewoll mgadewoll added the bug label May 15, 2024
@mgadewoll mgadewoll marked this pull request as ready for review May 15, 2024 09:54
@mgadewoll mgadewoll requested a review from a team as a code owner May 15, 2024 09:54
@tkajtoch tkajtoch self-requested a review May 15, 2024 13:28
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes locally and verified it fixes kibana tests. I'm happy to get this merged when Cee's comments are addressed :)

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for hopping on this Lene! Also, looking forward to when we can more frequently run EUI against Kibana CI to catch issues like this that only crop up in test environments 😭

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit 04d9aa4 into elastic:main May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiInputPopover] Removed setTimeout causes flaky test behavior
5 participants