Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDatePicker][a11y] Fix screen reader announcements on time selection and intermittently broken up/down navigation on NVDA/JAWS #7726

Merged
merged 5 commits into from
May 16, 2024
Merged

[EuiDatePicker][a11y] Fix screen reader announcements on time selection and intermittently broken up/down navigation on NVDA/JAWS #7726

merged 5 commits into from
May 16, 2024

Commits on May 16, 2024

  1. Fix incorrect aria-live 

    - should be on the parent element that *does not* dynamically change

- also needs a polite attribute! yikes
    @cee-chen
    cee-chen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1ea6887 View commit details
    Browse the repository at this point in the history

  2. Attempt to more aggressively capture focus/blur events?? 

    - trying to fix the issue where the up/down arrow keys don't work

- not sure if this is doing anything honestly, need Trevor to test on staging
    @cee-chen
    cee-chen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    dca8164 View commit details
    Browse the repository at this point in the history

  3. changelog

    @cee-chen
    cee-chen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f5cc568 View commit details
    Browse the repository at this point in the history

  4. Revert "Attempt to more aggressively capture focus/blur events??" 

    This reverts commit ae2b782.
    @cee-chen
    cee-chen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    399aa7e View commit details
    Browse the repository at this point in the history

  5. Improve screen reader experience further with aria-atomic="false"

    @cee-chen
    cee-chen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    03949be View commit details
    Browse the repository at this point in the history