Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.5](backport #2092) fix unenroll offline agents #2109

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 23, 2022

This is an automatic backport of pull request #2092 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix unenroll offline agents

* added changelog

* added unit test

* changed ErrNotFound error to an info log

* fixed error logic

(cherry picked from commit 3b22855)
@mergify mergify bot requested a review from a team as a code owner November 23, 2022 08:15
@mergify mergify bot added the backport label Nov 23, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Nov 23, 2022

This pull request has not been merged yet. Could you please review and merge it @juliaElastic? 🙏

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-23T08:15:42.727+0000

  • Duration: 12 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 363
Skipped 1
Total 364

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@juliaElastic
Copy link
Contributor

@elastic/elastic-agent-control-plane The ownership on main changed to fleet team, can we apply that on 8.6 and 8.5 branches?

This was referenced Nov 23, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Nov 29, 2022

This pull request has not been merged yet. Could you please review and merge it @juliaElastic? 🙏

@juliaElastic juliaElastic merged commit cdb6fda into 8.5 Nov 29, 2022
@juliaElastic juliaElastic deleted the mergify/bp/8.5/pr-2092 branch November 29, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants