Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProcTime.StartTime on Windows #52

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Oct 24, 2016

This converts the process creation time from Windows epoch to milliseconds since unix epoch. A test was added to sanity check the StartTime value.

Process creation and exit times are points in time expressed as the amount of time that has elapsed since midnight on January 1, 1601 at Greenwich, England.

Source: https://msdn.microsoft.com/en-us/library/windows/desktop/ms683223

This converts the process creation time from Windows epoch to milliseconds since unix epoch.
@codecov-io
Copy link

codecov-io commented Oct 24, 2016

Current coverage is 70.58% (diff: 100%)

Merging #52 into master will decrease coverage by 0.02%

@@             master        #52   diff @@
==========================================
  Files            10         10          
  Lines          1099       1098     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            776        775     -1   
  Misses          262        262          
  Partials         61         61          

Powered by Codecov. Last update 15322f7...c813e0b

@tsg
Copy link

tsg commented Oct 24, 2016

LGTM, waiting for travis.

@tsg tsg merged commit fcde510 into elastic:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants