[elasticsearch] add value to disable service (#1115) (#1339)

Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Nico Flaig <nflaig@protonmail.com>
elastic · Sep 21, 2021 · e10cdbd · e10cdbd
1 parent b0ea476
commit e10cdbd
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/elasticsearch/README.md b/elasticsearch/README.md
@@ -161,6 +161,7 @@ support multiple versions with minimal changes.
 | `secretMounts`                     | Allows you easily mount a secret as a file inside the StatefulSet. Useful for mounting certificates and other secrets. See [values.yaml][] for an example                                                                                                                                                         | `[]`                                             |
 | `securityContext`                  | Allows you to set the [securityContext][] for the container                                                                                                                                                                                                                                                       | see [values.yaml][]                              |
 | `service.annotations`              | [LoadBalancer annotations][] that Kubernetes will use for the service. This will configure load balancer if `service.type` is `LoadBalancer`                                                                                                                                                                      | `{}`                                             |
+| `service.enabled`                  | Enable non-headless service                                                                                                                                                                                                                                                                                       | `true`                                           |
 | `service.externalTrafficPolicy`    | Some cloud providers allow you to specify the [LoadBalancer externalTrafficPolicy][]. Kubernetes will use this to preserve the client source IP. This will configure load balancer if `service.type` is `LoadBalancer`                                                                                            | `""`                                             |
 | `service.httpPortName`             | The name of the http port within the service                                                                                                                                                                                                                                                                      | `http`                                           |
 | `service.labelsHeadless`           | Labels to be added to headless service                                                                                                                                                                                                                                                                            | `{}`                                             |

diff --git a/elasticsearch/templates/service.yaml b/elasticsearch/templates/service.yaml
@@ -1,4 +1,5 @@
 ---
+{{- if .Values.service.enabled -}}
 kind: Service
 apiVersion: v1
 metadata:
@@ -43,6 +44,7 @@ spec:
 {{- if .Values.service.externalTrafficPolicy }}
   externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
 {{- end }}
+{{- end }}
 ---
 kind: Service
 apiVersion: v1

diff --git a/elasticsearch/tests/elasticsearch_test.py b/elasticsearch/tests/elasticsearch_test.py
@@ -856,6 +856,23 @@ def test_scheduler_name():
     )
 
 
+def test_disabling_non_headless_service():
+    config = ""
+
+    r = helm_template(config)
+
+    assert uname in r["service"]
+
+    config = """
+service:
+  enabled: false
+"""
+
+    r = helm_template(config)
+
+    assert uname not in r["service"]
+
+
 def test_adding_a_nodePort():
     config = ""
 

diff --git a/elasticsearch/values.yaml b/elasticsearch/values.yaml
@@ -180,6 +180,7 @@ httpPort: 9200
 transportPort: 9300
 
 service:
+  enabled: true
   labels: {}
   labelsHeadless: {}
   type: ClusterIP