[elasticsearch] add value to disable service

[nflaig]

Hey guys,

right now it is not possible to completely disable the service but it is not required if the helm chart is deployed to a cluster with a service mesh (consul, istio, etc.).

Since the service.enabled does not apply to the headless service a different name could be considered but I think the issue rather is that both services use the same service value rather than service and serviceHeadless.

Fix #998

• Chart version not bumped (the versions are all bumped and released at the same time)
• README.md updated with any new values or changes
• Updated template tests in ${CHART}/tests/*.py
• Updated integration tests in ${CHART}/examples/*/test/goss.yaml

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[jmlrt]

LGTM⛴

[jmlrt]

jenkins test this please

[jmlrt]

will need to be rebased after #1141 merge to fix tests

[nflaig]

@jmlrt Thanks for the review! I added the new value to the README and will rebase the branch if required

[jmlrt]

jenkins test this please

[jmlrt]

Hi @nflaig, I rebased your branch on master and fixed the conflicts.
The change LGTM to me.

Adding a test in https://github.com/elastic/helm-charts/blob/master/elasticsearch/tests/elasticsearch_test.py to ensure that the service isn't created when setting service.enabled=false would be great.

Are you interested in adding this test? Otherwise I think we can merge if tests are successful.

[nflaig]

@jmlrt Thanks for rebasing the branch. I added a test to check if disabling the service works as expected if service.enabled is set to false. Also I noticed that the commit message was somehow overwritten I updated the commit to have the original message, I hope thats fine

[jmlrt]

Thanks for rebasing the branch. I added a test to check if disabling the service works as expected if service.enabled is set to false.

👍🏻

Also I noticed that the commit message was somehow overwritten I updated the commit to have the original message, I hope thats fine

Yes, sorry I messed it a bit while rebasing...

[jmlrt]

jenkins test this please